Patchset to make __func__ more visible

Michael Adam obnox at samba.org
Mon Nov 11 06:16:37 MST 2013


On 2013-11-05 at 10:43 +0100, Michael Adam wrote:
> On 2013-11-04 at 10:34 +0100, Volker Lendecke wrote:
> > 
> > Ah, and it's standard these days. I'd rather #define
> > __func__ in lib/replace if it's not there. At one point we
> > changed True/False to true/false for similar reasons if I
> > remember correctly.
> 
> And what is more, __FUNCTION__ seems to have been a gcc-specific
> addition, not standardized:
> 
> http://gcc.gnu.org/onlinedocs/gcc-4.8.1/gcc/Function-Names.html
> 
> So we should probably add __func__ to replace and replace use of
> __FUNCTION__ by __func__.
> 
> So for the time being, can we push Volker's fix for the debug
> statement? And possibly also the update to README.coding?
> I think both are valuable additions and don't require fixing
> all places or rewriting the debug system before they can be
> applied. :-)
> 
> So if no-one vetoes, I would push them.

Pushed to autobuild.

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131111/2919f14d/attachment.pgp>


More information about the samba-technical mailing list