[PATCH 2/2] s4:dsdb/rootdse: Support netlogon request

Andrew Bartlett abartlet at samba.org
Wed Nov 6 11:26:08 MST 2013

On Wed, 2013-11-06 at 12:55 +0100, Benjamin Franzke wrote:
> Hi Andrew,
> I've read a bit of the nbt code, to see whether I did some wrong guesses or
> so,
> but then i came to the conclusion maybe the data is invalidated (e.g.
> free'd) too early,
> before it is actually send out to the client.
> That would explain this occasional, hard-to-reproduce error.
> Then I found something that *probably* caused that.
> I used ldb_msg_add_value to add the netlogon blob to the message:
> https://git.bnfr.net/samba/tree/source4/dsdb/samdb/ldb_modules/rootdse.c?h=netlogon-5#n810
> That means it stays part of requests talloc tree, which may be freed before
> sending the message(?).
> ldb_msg_add_steal_value should be used instead.
> I've pushed a patch to my netlogon-8 branch,
> could you please run another autobuild to see whether that fixed it?

That would certainly do it.  

I'll re-run the tests.

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list