[Wireshark-dev] Wireshark PIDL generated dissectors

[mmann78 at netscape.net]

Private reply (as well)
 
That's all I did, which was the same change I made to the patch you submitted to Bugzilla as well.
 
Regarding your patch to reassembly.c - I've looked at it and it seems fine to me, but I don't know if I have enough knowledge to feel comfortable committing it.  I'm sure its fine for your needs, but I'm a little worried about breaking something else.  I was hoping someone else would look at it, but I may just commit it in a few days if no one has (because comments seem to come in more once it's committed ;) )
 
Michael
 

-----Original Message-----
From: Matthieu Patou <mat at samba.org>
To: mmann78 <mmann78 at netscape.net>
Cc: abartlet <abartlet at samba.org>; samba-technical <samba-technical at samba.org>
Sent: Mon, Nov 4, 2013 2:10 pm
Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors


On 11/04/2013 05:25 AM, mmann78 at netscape.net wrote:
> The issue is that Windows treats the guint3264 datatype as a 64-bit value and 
warns (which gets treated as errors) about the downgrade to a 32-bit value when 
passing "size" into tvb_new_subset()  and when doing the addition to "offset".  
Just a simple cast in both places is enough.
Private reply.

Just to be 100% sure a cast like that should do the trick ?

tvb_new_subset(tvb, offset, (gint)size, -1);

I'll modify the generator if it is so.

Should be trivial fix.

Matthieu.
>
>
> -----Original Message-----
> From: Matthieu Patou <mat at samba.org>
> To: mmann78 <mmann78 at netscape.net>; wireshark-dev <wireshark-dev at wireshark.org>
> Cc: abartlet <abartlet at samba.org>; samba-technical <samba-technical at samba.org>
> Sent: Mon, Nov 4, 2013 3:25 am
> Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors
>
>
> On 11/03/2013 08:26 AM, mmann78 at netscape.net wrote:
>> Matthieu,
>>
>> I committed 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch
> and 0016-Regenerate-the-dnserver.patch with the necessary changes to get it to
> compile on Windows to r53067.  As the commit message mentions, I think the 
PIDL
> generator may need to be updated in order for dissectors to compile on 
Windows.
> Which changes are needed ?
> It shouldn't be too hard to ask politely pidl to generate compatible
> code as long as I know what we have to generate.
>
> Matthieu
>


-- 
Matthieu Patou
Samba Team
http://samba.org