[PATCH v9] vfs_glusterfs: Samba VFS module for glusterfs

Anand Avati avati at redhat.com
Wed May 29 15:00:55 MDT 2013


On 5/29/13 1:58 PM, Jeremy Allison wrote:
> On Wed, May 29, 2013 at 01:54:20PM -0700, Anand Avati wrote:
>>
>> 3. In our test case the fd number returned by vfs_gluster for the
>> initial open file _was_ 0. That dirfd() condition needs a fix, I
>> think?
>
> Yep. That's why I fixed it in master and 4.0.x, it already came up in
> a breakage of a different vfs module that used the same trick.
>
>> I don't know if the master branch has equivalent code elsewhere,
>> couldn't find it easily..
>
> Oh now I understand, that's the broken code I fixed in master :-).
> It's already been back-ported to 4.0.x.
>
> You'll need to back port the dirfd removal fixes from 4.0.x to
> 3.6.x in order for this to wotk.
>

Phew! OK. That was a twisted rediscovery :-)

So that means v9 is still good as it is submitted against master. Merge 
please? :-)

Avati




More information about the samba-technical mailing list