[PATCH] libsmbconf: add smbconf_create_set_share

Michael Adam obnox at samba.org
Tue May 28 09:52:02 MDT 2013


Hi David,

On 2013-05-28 at 16:57 +0200, David Disseldorp wrote:
> On Tue, 21 May 2013 17:52:37 +0200
> Michael Adam <obnox at samba.org> wrote:
> 
> > If you are happy with the changes, we could squash them
> > together with your initial patch and submit this under
> > your copyright and
> > 
> > Pair-Programmed-With: /me 
> > and signed-off-by /me
> 
> I'm not sure whether you saw this go by on IRC, 

No, I did not notice, sorry. - Thanks for the mail :-)

> but I collapsed, tagged, rebased and pushed to:
>   git://git.samba.org/ddiss/samba.git libsmbconf_obnox
> 
> I've not pushed to autobuild, as I'm reluctant to add your s-o-b
> without knowing exactly which changes you wanted squashed.

Yes, that was exactly what I meant.

> Please push or ack if you're happy with what's there.

I am still only a little uncertain about the top patch
that simply bumps the version of the library to 1.
Is that all there is to it? Should we do it or rather
leave it at 0?

I pushed the first patches to autobuild, deferring
the version bump for further comments / advice.

Thanks - Michael



More information about the samba-technical mailing list