[PATCH] Remove the autoconf build system

Andrew Bartlett abartlet at samba.org
Mon May 27 07:00:18 MDT 2013


On Mon, 2013-05-27 at 15:00 +0200, David Disseldorp wrote:
> On Mon, 27 May 2013 15:40:18 +0300
> Alexander Bokovoy <ab at samba.org> wrote:
> 
> > Hi,
> > 
> > On Mon, May 27, 2013 at 3:26 PM, David Disseldorp <ddiss at suse.de> wrote:
> > 
> > > On Mon, 27 May 2013 21:26:16 +1000
> > > Andrew Bartlett <abartlet at samba.org> wrote:
> > >
> > > > > I don't consider this a blocker for now, but I'd like to see configure
> > > > > time PIE (--enable-pie) support re-added for vendors requiring address
> > > > > space layout randomization.
> > > >
> > > > I would be very glad to work with you on this.  What compiler and linker
> > > > flag to we need to add?
> > >
> > > cflags='-fPIE' and ldflags='-pie' on GCC. So something like:
> > >
> > >     if Options.options.enable_pie == True:
> > >         conf.ADD_CFLAGS('-fPIE')
> > >         conf.ADD_LDFLAGS('-pie')
> > >
> > > Not entirely correct. These options should be added *only* to executables.
> > They should not be used for anything else.
> > We already have PIC for others.
> 
> libtool distinguishes between static/shared libraries, and executables,
> and replaces -fPIE with the object specific (-fPIC/-fPIE) flag. I expect
> Waf would need object specific cflags/ldflags variables to cleanly
> handle this.

the SAMBA_LIBRARY and SAMBA_BINARY handlers should be able to help here.
They can read a flag set at configure time if it ends up in 'env' (see
for example how the code to disable the AD DC, or build with MIT krb5
works). 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list