[PATCH] Remove the autoconf build system

David Disseldorp ddiss at suse.de
Mon May 27 04:37:37 MDT 2013


Hi Andrew,

On Sun, 26 May 2013 19:38:55 +1000
Andrew Bartlett <abartlet at samba.org> wrote:

> On Fri, 2013-05-24 at 19:01 +1000, Andrew Bartlett wrote:
> > On Thu, 2013-05-23 at 13:36 +1000, Andrew Bartlett wrote:
> > > I've uploaded my patches to remove the autoconf build system to the
> > > remove-autoconf branch at git://git.samba.org/abartlet.samba.org
> > > 
> > > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/remove-autoconf
> 
...
> I would very much appreciate a technical review of this work, while we
> finish discussing this important move.  
> 
> I would also very much like to see a concrete proposal as to any changes
> needed to address Volker's workflow, rather than hold this patch and
> important decision up while waiting for someone to do something.  
> 
> My view is that the time for major feature requests for our use of waf
> was back when Tridge was implementing it for Samba, and that it is
> unreasonable to hold this back in the absence of a genuine proposal
> backed by actual working patches. 

Thanks for your persistence in getting things to this point.

I don't consider this a blocker for now, but I'd like to see configure
time PIE (--enable-pie) support re-added for vendors requiring address
space layout randomization.

Otherwise, the change set looks good:
Reviewed-by: David Disseldorp <ddiss at samba.org> 

Cheers, David


More information about the samba-technical mailing list