[PATCH] pmda: handle new ctdb_statistics format

Michael Adam obnox at samba.org
Sun May 26 16:05:26 MDT 2013


Hi David,

pushed to ctdb master.

On 2013-05-26 at 23:23 +0200, David Disseldorp wrote:
> Hi Andrew,
> 
> On Sat, 25 May 2013 08:06:41 +1000
> Andrew Bartlett <abartlet at samba.org> wrote:
> 
> > > The ctdb_statistics structure was recently changed. Update the PMDA to
> > > dereference the new structure member names.  
> > 
> > Do we need to change our build system to ensure this is always built in
> > autobuild, in the samba-ctdb build?

Andrew,

this is a pure ctdb patch.
Samba's samba-ctdb target does not build or test ctdb,
it only builds samba with clustering enabled.

> I'm happy maintaining it as-is for the moment, but if others see use
> in the monitoring agent, then the Performance Co-Pilot development
> package could be added to our autobuild systems.

We can try to ensure it gets built in the ctdb build,
but it has dependencies, so we would need to protect it
with configure checks, and without installing libpcp-pmda3-dev
and some other packages it would not get built.

Once we have ctdb in the samba tree and autobuild system,
we can ensure that it always gets built and can avoid
regressions.

Cheers - Michael



More information about the samba-technical mailing list