[PATCH 2/3 v4] vfs_posixacl: expose acl_t <--> smb_acl_t converter functions

[Simo]

On 05/24/2013 04:41 AM, Andrew Bartlett wrote:
> On Thu, 2013-05-23 at 22:29 -0400, Anand Avati wrote:
>> These converters are used in vfs_glusterfs for storing posix acls
>> as xattrs (where acl_set_file does not work)
> I was all keen to submit this to autobuild, but it doesn't even compile:
>
> [2693/3956] Compiling source3/lib/sysacls.c
> In file included from ../source3/lib/sysacls.c:26:0:
> ../source3/modules/vfs_posixacl.h:47:39: error: unknown type name
> ‘acl_t’
> ../source3/modules/vfs_posixacl.h:48:1: error: unknown type name ‘acl_t’
> Waf: Leaving directory `/data/samba/git/samba-push/bin'
> Build failed:  -> task failed (err #1):
> 	{task: cc sysacls.c -> sysacls_92.o}
> make: *** [all] Error 1
>
> I think we need to make glusterfs depend on posix ACLs (presumably the
> converter function you use) and have these header definitions depend on
> whatever provides acl_t.
>
> In general we don't like conditional stuff in our headers, which is why
> there is the whole smb_acl stuff in the first place, but this is a bit
> of a special case.
>

I proposed to move acl handling in the core at least for 4.1, see my 
review email.

Simo.