[PATCH] remove pidl check-clean-tree check from autobuild

jelmer at samba.org jelmer at samba.org
Thu May 23 05:23:12 MDT 2013


On Thu, May 23, 2013 at 01:44:06PM +1000, Andrew Bartlett wrote:
> I've been testing the remove-autoconf branch, and I hit up against this
> issue.  On Fedora 18, I just can't do an autobuild locally until I
> remove this check-clean-tree check.
> 
> I think it's safe to remove, because while the script talks about
> uncommited changes, the way autobuild works it only sees real commits.
> What it does find (very well) is additional or changed files generated
> by the build process in the source tree, ABI files in particular.
> 
> In pidl, we re-generate with yapp some files, but we do it in place.
> Sadly something has changed, and the output order has changed.  I can't
> just commit the result, because others would get the error as it changes
> back (the old commited configure script issue).  So I think the best
> thing is to remove this check from autobuild, for pidl ONLY.
> 
> Comments and better suggestions welcome, as is review/push if this is
> the best approach.
Dropping this test means dropping out of tree build support. Do we really want
to do that?

Cheers,

Jelmer


More information about the samba-technical mailing list