[PATCH] Do not always regenerate version.h

[Michael Adam]

Hi Andrew,

On 2013-05-23 at 10:13 +1000, Andrew Bartlett wrote:
> On Wed, 2013-05-22 at 16:56 -0700, Jeremy Allison wrote:
> > 	You've been requested many times to add a Signed-off-by:
> > line to patches, and all other Team members (to my knowledge)
> > now do so.
> 
> I've explained that I don't like that there seems to be two different
> meanings for Signed-off-by, one in the wiki (which on it's own would be
> perfectly reasonable, if not very precise), and other very specific
> meaning in https://www.samba.org/samba/devel/copyright-policy.html

There are no two different meanings!
(Was my previous mail about the topic so uncear or don't you
take me seriously here because I am not a native english speaker?  :-)

Here is the most important distinction again:

- The Wiki (together with the original Kernel reference) is the
  general rule and description of the meaning of signed-off for us.
  (I can happily add precision if desired.)

- The copyright policy page is NOT the general rule.
  It does IN PARTICULAR contain a reference to signed-off,
  as part of the description of what is necessary to have
  corporate copyright accepted.

If it helps you resolve your conflict, we can very well add
a remark to the copyright policy page, and possibly also
(if we agree) put the general rule for patch submission and
signing-off into a proper web-page on www.samba.org.

> > I'm afraid I won't be reviewing/pushing any more of your patches
> > unless you adopt the convention that everyone else follows. At
> > this point it's a matter of good practice.
> > 
> > It's as simple as typing '-s' on the git command line when
> > committing the patch, so I really don't see your objection
> > to doing so.
> 
> I'm seeking advise on the matter.

By whom?

Do you mean externally?
...Because you don't -yet- seem to accept the advice given by the
samba developers... ;-)

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 206 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130523/9cf097ec/attachment.pgp>