[PATCHS] allow samba to replicate modificated schema properly both on initial join and on incremental changes

Stefan (metze) Metzmacher metze at samba.org
Thu May 23 01:42:24 MDT 2013


Hi Matthieu,

as discussed on irc here's the patchset I'd like to have in master.

> I'm planning to push this branch
> http://git.samba.org/mat/?p=mat/samba.git;a=shortlog;h=refs/heads/fix-drs-testing-metze
> 
> to autobuild soon
> 
> It's the same as what we did with metze with the addition of the two
> following patches.

> Subject: [PATCH 1/2] dsdb: Fix talloc issues in dsdb_schema_copy_shallow
>
> The problem was that we did not clear these structure members before
> we regenerated these values in schema_fill_constructed().  The
> talloc_realloc() in the schema_fill_possible_inferiors() and
> schema_fill_system_possible_inferiors() calls would then use the old
> talloc parent (cls, a child of schema) not cls_copy (a child of
> schema_copy).

This isn't needed, the fix belongs to schema_fill_possible_inferiors(), see
https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=4affae26c301fcbeeb7fb80437c074d80f922547

I've squashed the other commit into the patches, which introduced this,
thanks for finding this!

metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 48165 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130523/1bd2c844/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130523/1bd2c844/attachment-0001.pgp>


More information about the samba-technical mailing list