[PATCH] Fix build on hosts that won't allow var = {} initialisation
Andrew Bartlett
abartlet at samba.org
Wed May 22 23:42:32 MDT 2013
On Wed, 2013-05-22 at 21:38 -0700, Richard Sharpe wrote:
> On Wed, May 22, 2013 at 5:11 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> > On Tue, 2013-05-21 at 23:18 -0700, Richard Sharpe wrote:
> >> On Tue, May 21, 2013 at 10:11 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> >> > On Tue, 2013-05-21 at 21:51 -0700, Richard Sharpe wrote:
> >> >> On Tue, May 21, 2013 at 2:47 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> >> >> > This build failure is preventing a number of build farm hosts from
> >> >> > building, and in turn is making it harder to do config.h difference
> >> >> > comparisons for bug 8969.
> >> >> >
> >> >> > Please review/push.
> >> >>
> >> >> It looks OK. However, there is no signed-off-by line.
> >> >
> >> > https://www.samba.org/samba/devel/copyright-policy.html describes the
> >> > meaning of Signed-off-by for Samba, but as I own my copyright personally
> >> > and so have not mailed in that statement (including LGPL permission), it
> >> > does not apply to me.
> >> >
> >> > In consideration of the above, I choose not to add this line to avoid
> >> > any further confusion as to the licence or circumstances under which I
> >> > provide my code.
> >>
> >> OK. Reviewed and pushed.
> >
> > I don't see it in master, did something go wrong with this, or was there
> > a mix-up with my md5 patch perhaps?
>
> Is it not this one?
>
> commit 30a224367595f9e2506e41053fc9c7cb96a90928
> Author: Andrew Bartlett <abartlet at samba.org>
> Date: Wed May 22 00:14:19 2013 +1000
>
> build: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd
>
> This brings the two build systems in sync, without using md5.h (which is a p
>
> Tested on FreeBSD
>
> Andrew Bartlett
>
> Reviewed-by: Richard Sharpe <rsharpe at samba.org>
>
> Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
> Autobuild-Date(master): Wed May 22 10:06:40 CEST 2013 on sn-devel-104
No, the patch I was proposing is attached. What you pushed is another
patch I was also proposing (I've been busy).
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smbd-Fix-build-on-platforms-that-will-not-support-va.patch
Type: text/x-patch
Size: 897 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130523/e0f6d75e/attachment.bin>
More information about the samba-technical
mailing list