[PATCH] remove pidl check-clean-tree check from autobuild

Andrew Bartlett abartlet at samba.org
Wed May 22 21:44:06 MDT 2013


I've been testing the remove-autoconf branch, and I hit up against this
issue.  On Fedora 18, I just can't do an autobuild locally until I
remove this check-clean-tree check.

I think it's safe to remove, because while the script talks about
uncommited changes, the way autobuild works it only sees real commits.
What it does find (very well) is additional or changed files generated
by the build process in the source tree, ABI files in particular.

In pidl, we re-generate with yapp some files, but we do it in place.
Sadly something has changed, and the output order has changed.  I can't
just commit the result, because others would get the error as it changes
back (the old commited configure script issue).  So I think the best
thing is to remove this check from autobuild, for pidl ONLY.

Comments and better suggestions welcome, as is review/push if this is
the best approach.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-autobuild-Do-not-check-for-a-clean-tree-in-pidl-as-n.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130523/3178b458/attachment.bin>


More information about the samba-technical mailing list