[PATCH]: core files with make testenv

[Michael Adam]

On 2013-05-07 at 00:12 +0200, Michael Adam wrote:
> Hi,
> 
> I think these are good.
> 
> (i.e. "Reviewed-by: Michael Adam <obnox at samba.org>")
> 
> Anyone else?
> 
> I have analyzed the use of dump_core_setup() some more.
> And I think we can do much better in the daemon start code.
> 
> Attached find a patchset that makes smbd,nmbd, and winbindd
> all behave the same, so that they call dump_core_setup() four
> times during startup to adapt to potential changes of the
> logfile base:
> 
> - right at the start
> - after parsing the command line
> - after initial config loading (without registry)
> - after loading the full config
>   (Or should we rather re-setup the core as part of the functions
>    reload_services/reload_nmbd_services/reload_services_file ?)

One might also argue that we should not change the corepath so
frequently, but call dump_core_setup() only once, in order to
not potentially clutter the system with core files.

To follow that paradigm, we should only call dump_core_setup()
at the last point, after loading the full config and accept
the drawback that we can possibly not dump cores before that.

What do people think of these two possible approaches to fixing
our core path handling?

Thanks - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 206 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130522/7e2dd29f/attachment.pgp>