[PATCH] winbind4: honor the settings of winbind enum users / groups

Andrew Bartlett abartlet at samba.org
Sat May 18 03:02:04 MDT 2013


On Sat, 2013-05-18 at 10:54 +0200, Kai Blin wrote:
> On 17/05/13 12:28, Andrew Bartlett wrote:
> > On Fri, 2013-05-17 at 12:17 +0200, Björn Jacke wrote:
> >> On 2013-05-17 at 20:08 +1000 Andrew Bartlett sent off:
> >>> On Fri, 2013-05-17 at 11:06 +0200, Björn Jacke wrote:
> >>>> [PATCH] winbind4: honor the settings of winbind enum users / groups
> >>>
> >>> Nice work.
> >>
> >> however only tested and compiling with 4.0, for master I send an updated
> >> patch later on.
> >
> > I would be truly socked if it doesn't just work.  Of course, now you
> > mention it, you should probably add a test somewhere :-)
> 
> Actually, the autobuild failed with
> 
> [1487/1567 in 1h12m28s] samba4.winbind.struct(plugin_s4_dc)
> Running WINBINDD_GETPWENT (struct based)
>   - Running WINBINDD_SETPWENT first
>   - Running WINBINDD_GETPWENT now
> UNEXPECTED(failure): samba4.winbind.struct.getpwent(plugin_s4_dc)
> REASON: _StringException: _StringException: 
> ../source4/torture/winbind/struct_based.c:860: WINBINDD_GETPWENT 
> returned 0, expected 1
> 
> Björn, could you check if the test expects enum to work but the config 
> file used in the tests disables it?

We should probably have one environment that enables this, one that
disables it and use knownfail entries to ensure both do the right thing.
That would cover the testing required.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list