LDB patches the return

[Andrew Bartlett]

On Fri, 2013-05-17 at 10:09 -0700, Matthieu Patou wrote:
> Hello all,
> 
> This is the return of my patches for LDB, here is a first set of 
> patches, per se they are not useful it's just the foundation for the 
> other patches.
> 
> Having them already reviewed will ease the review process for the core ones.
> 
> b0bb3d6 ldb: Make ldb_match_scope and ldb_match_message available to 
> other ldb parts
> 9850a73 ldb: Add ldb_dn_set_casefolded so that a DN can marked as 
> already casefolded
> 986712d ldb: introduce ldb_unpack_data_withlist to unpack partial list 
> of attributes
> 55794d1 ldb-tdb: split ldb_match_msg_error by 2 seprate calls to 
> ldb_match_scope + ldb_match_message
> 3cf098d ldb: Upgrade to version 1.1.16 due to newly added functions
> 
> They are in my wait_reviews branch at 
> http://git.samba.org/mat/?p=mat/samba.git;a=shortlog;h=refs/heads/wait_reviews
> 
> Please review but do not push

It would be really good to have a unit test of the unpack code, that
unpacked a known blob and showed that we got either the full list or
short list as appropriate. 

The reason I mention it is that because of the way the layers above
work, a regression here wouldn't ever be noticed, except in
performance. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org