[PATCH] libsmbconf: add smbconf_create_set_share

Alexander Bokovoy ab at samba.org
Thu May 16 05:42:56 MDT 2013


Hi,


On Thu, May 16, 2013 at 12:55 PM, David Disseldorp <ddiss at samba.org> wrote:

> This call creates a new share definition, using the parameters provided
> with a smbconf_service structure.
> Such an interface allows for simple cloning of services with:
> smbconf_get_share(conf_ctx, mem_ctx, base_sharename, &base_service_def);
> base_service_def->name = clone_sharename;
> smbconf_create_set_share(conf_ctx, clone_sharename, base_service_def);
>
Looks OK but I thought to ask for proper ABI handling for libsmbconf since
it is public library. Should we actually increment its ABI version (it has
none right now) with this change?


-- 
/ Alexander Bokovoy


More information about the samba-technical mailing list