[PATCH] Tidyup. Remove a bunch of "unused variable _relative_save_offset" warnings.

Jeremy Allison jra at samba.org
Fri May 10 09:56:33 MDT 2013


On Fri, May 10, 2013 at 09:34:10AM +0200, Andreas Schneider wrote:
> On Wednesday 08 May 2013 09:58:56 Jeremy Allison wrote:
> > Ok, pushed. This does teach us not to ignore warnings
> > however - there was an actual bug there (just not the
> > one I fixed :-).
> > 
> > I'd like to have a code sprint sometime soon where
> > we eliminate as many compiler warnings out of the
> > master branch as possible. We used to be virtually
> > warning-free, we've let this slip too much recently
> > and we need to fix it up (IMHO).
> 
> I normally compile use -pedantic and -pedantic-error in my projects which 
> forces you to write cleaner code. I would vote to use them in Samba too :)

Yep ! But first we need to get there, and then we
turn them on to stop us sliding back :-).

Maybe you and I can work together on eliminating
all warnings over the next few months ?

Jeremy


More information about the samba-technical mailing list