[PATCH] Tidyup. Remove a bunch of "unused variable _relative_save_offset" warnings.
Jeremy Allison
jra at samba.org
Wed May 8 10:58:56 MDT 2013
On Wed, May 08, 2013 at 12:19:50PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
>
> > Please review and push if you're happy.
> >
> > Fixes a boatload of compliler warnings when
> > processing the code generated from IDL files
> > for me :-).
>
> I think this change is not correct, it's a bug that this
> variables are not used.
>
> Please have a look at the attached fixes and push them if you're happy
> with them.
Ok, pushed. This does teach us not to ignore warnings
however - there was an actual bug there (just not the
one I fixed :-).
I'd like to have a code sprint sometime soon where
we eliminate as many compiler warnings out of the
master branch as possible. We used to be virtually
warning-free, we've let this slip too much recently
and we need to fix it up (IMHO).
Cheers,
Jeremy.
More information about the samba-technical
mailing list