[PATCH] Add tests for our NFSv4 ACL code

Andrew Bartlett abartlet at samba.org
Wed May 8 03:45:00 MDT 2013


On Tue, 2013-05-07 at 17:01 -0700, Jeremy Allison wrote:
> On Fri, May 03, 2013 at 08:56:07AM -0700, Jeremy Allison wrote:
> > On Fri, May 03, 2013 at 06:55:23PM +1200, Andrew Bartlett wrote:
> > > On Fri, 2013-05-03 at 06:34 +0200, Alexander Werth wrote:
> > > > On Fri, 2013-05-03 at 13:59 +1200, Andrew Bartlett wrote:
> > > > > On Fri, 2013-05-03 at 03:10 +0200, Alexander Werth wrote:
> > > > > 
> > > > > > 
> > > > > > What else would be needed before the changes can be applied to master?
> > > > > 
> > > > > The patch for testing creator_owner still has incorrect knownfail
> > > > > entries. 
> > > > > 
> > > > > It doesn't pass make test TESTS=acls
> > > > 
> > > > Fixed.
> > > > ALL OK (77 tests in 8 testsuites)
> > > > 
> > > > I also added an update to the vfs_gpfs man page.
> > > 
> > > I've marked these as Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > > in my nfsv4-3 branch.  I just need another team member to review my
> > > changes, so we can push this fine collaboration.
> > > 
> > > Thanks for all your effort and patience here!
> > 
> > I'm at an offsite for the rest of the week, but
> > I'll start a review of these on Monday (Pacific
> > Time).
> 
> Ok, here is the complete patchset I've reviewed
> and added my "Reviewed-by:" lines to.
> 
> I fixed a few issues in the code - some missing
> TALLOC_FREE(frame) calls, one missing error check
> on a TALLOC_REALLOC and an update to Makefile.in
> for the autoconf build.
> 
> I also added a couple of (small) tidy-up fixes
> of my own - so Andrew please just review those
> for correctness before pushing to autobuild.
> 
> This set also includes Christian Ambach's build
> breakage fixes for AIX.

Thanks Jeremy,

I also need the attached fix, to build the changes with autoconf,
reviewed.  If someone can give their review, I can merge the rest!

(Alternately, the whole series in a duplicate mail awaiting moderation)

Sorry about that.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Add-vfs_nfs4acl-to-the-autoconf-build.patch
Type: text/x-patch
Size: 2228 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130508/64e96dcb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130508/64e96dcb/attachment.pgp>


More information about the samba-technical mailing list