[PATCH] Fix bug #9130 - Certain xattrs cause Windows error 0x800700FF
jra at samba.org
Thu Mar 28 13:25:05 MDT 2013
On Thu, Mar 28, 2013 at 12:17:06PM -0700, Jeremy Allison wrote:
> On Thu, Mar 28, 2013 at 12:13:53PM -0700, Jeremy Allison wrote:
> > >
> > > No, that's actually incorrect. smbtorture raw.eas actually
> > > tests for asking for an EA that dosn't exist by name using
> > > an SMB1 EA list query, and Windows returns an EA entry containing
> > > the requested name, with a zero length. So the current code
> > > in both smbd and ntvfs for that case is correct.
> > >
> > > We could expand the test to ask for 2 EA's in a list, one
> > > that exists and one that doesn't, but my guess is it does
> > > return an entry for each EA name requested, with a zero
> > > length showing that value doesn't exist (if you want to
> > > add that test feel free :-).
> > Ah. Actually thinking about it that means your request
> > to update eas->num_eas++ inside the strcasecmp_m test
> > was an error, as we need to return a NULL value for a
> > non existing EA.
> In fact it means my original change here was
> the correct one. Oops :-). I'll put it back :-).
Final changeset. David - speak now, or get your Reviewed-by tag
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 14346 bytes
Desc: not available
More information about the samba-technical