[PATCH] build and use-after free fixes found during Solaris work

[Jeremy Allison]

On Thu, Mar 28, 2013 at 08:50:57AM +1100, Andrew Bartlett wrote:
> On Wed, 2013-03-27 at 09:47 -0700, Jeremy Allison wrote:
> > On Wed, Mar 27, 2013 at 11:26:36AM +0100, Volker Lendecke wrote:
> > > On Wed, Mar 27, 2013 at 12:34:19PM +1100, Andrew Bartlett wrote:
> > > > On Solaris-derived systems (OpenIndiana in this case) I found we needed
> > > > to avoid the libidmap.so name, and I found a use-after-free in the auth
> > > > code at debug level 5.
> > > > 
> > > > See Attached, please review and or push.
> > > 
> > Pushed to autobuild with talloc_free -> TALLOC_FREE change.
> 
> When I tried to push the idmap change, it broke the idmap.rfc2307 test.
> I think we must rely on the subsystem name more broadly, so I'll need to
> find another way out for this, perhaps putting the -samba4 suffix back
> on our private but not bundled libraries. 
> 
> (And I'm *so* glad this now has an automated test)
> 
> Thanks,

Yep. I re-pushed without the idmap change, so we should have the
other fix shortly.

Jeremy.