[PATCH] build and use-after free fixes found during Solaris work

Simo idra at samba.org
Wed Mar 27 06:31:59 MDT 2013


On 03/27/2013 06:23 AM, Volker Lendecke wrote:
> On Wed, Mar 27, 2013 at 01:38:45PM +1100, Andrew Bartlett wrote:
>> On Wed, 2013-03-27 at 13:00 +1030, Rusty Russell wrote:
>>> Andrew Bartlett <abartlet at samba.org> writes:
>>>
>>>> On Solaris-derived systems (OpenIndiana in this case) I found we needed
>>>> to avoid the libidmap.so name, and I found a use-after-free in the auth
>>>> code at debug level 5.
>>>>
>>>> See Attached, please review and or push.
>>> Hmm... I can't git-am that mail, since it applies it as one commit.
>>>
>>> If I munpack to extract the attachmentds, git-am doesn't like the >
>>> before the top from, so I have to edit it manually.
>> Yeah, it seems if the patch ever goes via an mbox format at any point in
>> the path, the From lines get munged.  Sadly it's not something I can
>> easily fix in my workflow/mailer.
> In case you are using mutt,
>
> set encode_from=yes
>
> in your .muttrc helps here.
>
>>> Finally, you didn't Sign-off either of them, but that seems normal?
>> Yes, that's normal.  We only defined a protocol for that for corporate
>> contributors with LGPL licence to the team, as I own my own copyrights,
>> I don't want to add to the confusion.
> Oh, ok. I did not know that the people who have personal
> copyright are supposed to NOT do the signed-off thingy.
> Sorry, I tried to do that because my understanding from
> talking to Michael was different.
>
You did not know because Andrew just made that up.

Please keep using Signed-off-by.
When in doubt follow the same guidelines the kernel READMEs recommend 
limited to the Singed-off-by and Reviewed-by headers for now.

Simo.



More information about the samba-technical mailing list