[PATCH] build and use-after free fixes found during Solaris work

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Mar 27 04:23:22 MDT 2013


On Wed, Mar 27, 2013 at 01:38:45PM +1100, Andrew Bartlett wrote:
> On Wed, 2013-03-27 at 13:00 +1030, Rusty Russell wrote:
> > Andrew Bartlett <abartlet at samba.org> writes:
> > 
> > > On Solaris-derived systems (OpenIndiana in this case) I found we needed
> > > to avoid the libidmap.so name, and I found a use-after-free in the auth
> > > code at debug level 5.
> > >
> > > See Attached, please review and or push.
> > 
> > Hmm... I can't git-am that mail, since it applies it as one commit.
> > 
> > If I munpack to extract the attachmentds, git-am doesn't like the >
> > before the top from, so I have to edit it manually.
> 
> Yeah, it seems if the patch ever goes via an mbox format at any point in
> the path, the From lines get munged.  Sadly it's not something I can
> easily fix in my workflow/mailer. 

In case you are using mutt,

set encode_from=yes

in your .muttrc helps here.

> > Finally, you didn't Sign-off either of them, but that seems normal?
> 
> Yes, that's normal.  We only defined a protocol for that for corporate
> contributors with LGPL licence to the team, as I own my own copyrights,
> I don't want to add to the confusion. 

Oh, ok. I did not know that the people who have personal
copyright are supposed to NOT do the signed-off thingy.
Sorry, I tried to do that because my understanding from
talking to Michael was different.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list