[PATCH] Re: build failure in vfs_btrfs with current master

[David Disseldorp]

Hi Andrew,

On Wed, 20 Mar 2013 12:52:39 +1100
Andrew Bartlett <abartlet at samba.org> wrote:

> On Tue, 2013-03-19 at 19:27 +0100, Andreas Oster wrote:
> > Hi all,
> > 
> > today I have cloned the current master with:
> > 
> > git clone git://git.samba.org/samba.git samba4
> > 
> > and tried to compile samba4 using the following sequence:
> > 
> > ./configure.developer
> > make
> > 
> > but make fails with the following error message:
> > 
> > [3257/4102] Compiling source3/modules/vfs_btrfs.c
> > ../source3/modules/vfs_btrfs.c: In function ‘btrfs_copy_chunk_send’:
> > ../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects
> > argument of ty
> > ../source3/modules/vfs_btrfs.c:118:3: error: format ‘%ld’ expects
> > argument of ty
> > ../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects
> > argument of ty
> > ../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects
> > argument of ty
> > ../source3/modules/vfs_btrfs.c: In function ‘btrfs_copy_chunk_recv’:
> > ../source3/modules/vfs_btrfs.c:180:2: error: format ‘%lu’ expects
> > argument of ty
> > cc1: some warnings being treated as errors
> > Waf: Leaving directory `/home/administrator/source/samba4/bin'
> > Build failed:  -> task failed (err #1):
> >         {task: cc vfs_btrfs.c -> vfs_btrfs_80.o}
> > make: *** [all] Error 1
> 
> Each argument needs to match the printf declaration.  
> 
> > this system is using Ubuntu 12.04.2 LTS (GNU/Linux 3.2.0-39-generic-pae
> > i686)  32bit.
> 
> The types being printed are 64 bit, but the unsigned long varies between
> 32 and 64 bits long depending on the host.  So we change it all to long
> long types that don't vary between what the type is and what printf has
> a format string for. 
> 
> The attached patch should help. 
> 
> David,
> 
> Can you review and push?

The patch looks good, sorry for the delay in getting to it. Could you
please rebase on top of Rusty's change?

Cheers, David