[PATCH] Don't pass CPP="" to pidl Re: Cannot build Samba 4.0.4 on Solaris 11

[TAKAHASHI Motonobu]

From: Andrew Bartlett <abartlet at samba.org>
Date: Fri, 22 Mar 2013 13:58:07 +1100

> On Fri, 2013-03-22 at 13:12 +1100, Andrew Bartlett wrote:
>> On Fri, 2013-03-22 at 02:05 +0900, TAKAHASHI Motonobu wrote:
>> > $ gmake V=1
>> > (snip)
>> > [ 124/3763] Compiling IDL librpc/idl/atsvc.idl
>> > 02:00:39 runner  cd .. && CPP="" CC="/usr/bin/gcc" /usr/bin/perl
>> > "/home/monyo/Work/Samba/sol-x64/samba-4.0.4/pidl/pidl" --quiet --header
>> > --ndr-parser --samba3-ndr-server --server --client --python --outputdir
>> 
>> The issue is clearly that CPP="" has been set somehow.  Have you forced
>> this in some way in your environment?  If not, can you share you
>> config.log so we can work out how this has been set?
>> 
>> PIDL then attempts to compile the idl files with this substituted in,
>> and of course sh doesn't make a very good compiler :-)
> 
> Inspection of the waf CPP detection indicates that "" is a plausible
> value if no CPP is found, so this avoids passing that value to PIDL.
> 
> I also fix up some mis-handling of multi-part CC values (such as "ccache
> gcc").
> 
> Metze/Matthieu/Michael:  Please review/push.

Thanks, to apply this patch, build process can be complete.

---
TAKAHASHI Motonobu <monyo at monyo.com> / @damemonyo 
                   facebook.com/takahashi.motonobu