[PATCH] Re: build failure in vfs_btrfs with current master
Andrew Bartlett
abartlet at samba.org
Wed Mar 20 01:16:48 MDT 2013
On Wed, 2013-03-20 at 08:12 +0100, Stefan (metze) Metzmacher wrote:
> Am 20.03.2013 02:52, schrieb Andrew Bartlett:
> > - DEBUG(5, ("BTRFS_IOC_CLONE_RANGE failed: %s, length %lu, "
> > - "src fd: %ld off: %lu, dest fd: %d off: %lu\n",
> > - strerror(errno), cr_args.src_length,
> > - cr_args.src_fd, cr_args.src_offset,
> > - dest_fsp->fh->fd, cr_args.dest_offset));
> > + DEBUG(5, ("BTRFS_IOC_CLONE_RANGE failed: %s, length %llu, "
> > + "src fd: %lld off: %llu, dest fd: %d off: %llu\n",
> > + strerror(errno),
> > + (unsigned long long)cr_args.src_length,
> > + (long long)cr_args.src_fd,
> > + (unsigned long long)cr_args.src_offset,
> > + dest_fsp->fh->fd,
> > + (unsigned long long)cr_args.dest_offset));
>
> If the src fd should just use %d as the dst fd, it's just 'int'.
It isn't! (I fell for that the first time)
struct btrfs_ioctl_clone_range_args {
int64_t src_fd;
uint64_t src_offset;
uint64_t src_length;
uint64_t dest_offset;
};
(or we could/should change that private struct).
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical
mailing list