[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

Jeremy Allison jra at samba.org
Fri Mar 15 09:43:36 MDT 2013


On Fri, Mar 15, 2013 at 07:24:05AM +0100, Stefan (metze) Metzmacher wrote:
> 
> I think we should keep it all in one changeset.
> Currently I think the client changes (execpt the tcp_len patch)
> are just for testing.

No, we do need to keep the change to cause us to send CAP_LARGE_READX/
CAP_LARGE_WRITEX in the sessionsetupX request (as the 3.6.x client
code does). Also the new smbtorture test code depends on the client
changes to be able to send the 0xFFFF0001 read request (and other
requests larger than 0x1FFFF, 0xFFFFFF). So I don't think the client
changes can be removed without removing the entire new test case
(which I don't think we should do).

Jeremy.


More information about the samba-technical mailing list