[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

[Jeremy Allison]

On Thu, Mar 14, 2013 at 05:12:19PM +0100, Andreas Schneider wrote:
> 
> If nobody complains till tomorrow I will review again and push it. Time to 
> knock off now ;)

So hang fire on pushing this please (Michael and Metze also :-),
as I decided I needed to do one more test before I know *exactly*
how things should behave here (and I'm home now so this will have to
wait until I get back into work tomorrow and back to my W2K12
VM box :-).

What does Windows return for a readX call of length: 0x22000001 ?
This is way beyond any NetBIOS possible length even if using the
unix extensions trick of using 24 bit lengths.

There are 3 options.

1). Return invalid parameter (this is what we currently do).
2). Return a read of length 1 (this means they mask with 0x1FFFF
and truncate above length 0x10000).
3). Return a read of length 0x10000 (this means they just treat
all reads > 0x10000 as requests of length 0x10000).

And of course I want to test with the client sending CAP_LARGE_READX
and not sending CAP_LARGE_READX.

So I'm going to do those tests before deciding if this patchset
is the correct one or might need further changes in the patch
that modifies the server read response (I'm pretty happy with
the client-side changes in the patchset, but we might was well
keep it all in one changeset).

Cheers,

	Jeremy.