[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

[Andreas Schneider]

On Thursday 14 March 2013 09:01:40 Jeremy Allison wrote:
> On Thu, Mar 14, 2013 at 04:39:32PM +0100, Andreas Schneider wrote:
> > On Wednesday 13 March 2013 17:16:12 Jeremy Allison wrote:
> > > On Tue, Mar 12, 2013 at 08:14:00AM +0100, Stefan (metze) Metzmacher 
wrote:
> > > > Am 11.03.2013 22:54, schrieb Jeremy Allison:
> > > > > On Mon, Mar 11, 2013 at 01:55:12PM -0700, Jeremy Allison wrote:
> > > > >> We need to tweak the 'large read' detection code some more...
> > > > > 
> > > > > Ok, here's a version with the correct MS-doc reference
> > > > > in the comment, and also a better order of tests in the
> > > > > second part.
> > > > > 
> > > > > Please review (and test :-) and push if you're happy.
> > > > 
> > > > Can you write some tests which verifies both patches?
> > > 
> > > Ok, here is the patchset I've attached to the bug.
> > > Applies cleanly to 4.0.next.
> > > 
> > > It includes a new test suite, LARGE_READX which tests around the
> > > boundaries
> > > of large readX calls with read requests of:
> > > 
> > > 0xFFFF0001 (which should return 1 byte).
> > > 0x10000 (which should always return 0x10000)
> > > 0x1FFFF (which returns 0x1FFFF on Samba, and 0x10000 on Windows)
> > > 0x100000 (which returns 0x100000 on Samba, and 0x10000 on Windows).
> > 
> > Hi Jeremy,
> > 
> > we got a new bug at Red Hat. libsmbclient 4.0.3 against smbd 3.0.32. I
> > think this could be the client bug you fixed.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=920536
> > 
> > If you look at packet #177 you can see that the file size is 34441. In
> > packet #180 we request to read 64512 bytes. Packet #197 returns 34441
> > bytes (so the complete file). In packet #202 we try to read 1022 bytes at
> > offset 64512, but we already read the complete file. So we get an error
> > in packet #203.
> Yes, that is certainly the client bug I fixed.
> 
> Please feel free to push the patchset :-).

If nobody complains till tomorrow I will review again and push it. Time to 
knock off now ;)


	-- andreas


-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org