[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

[Stefan (metze) Metzmacher]

Hi Jeremy,

>>> Please review (and test :-) and push if you're happy.
>>
>> Can you write some tests which verifies both patches?
> 
> Ok, here is the patchset I've attached to the bug.
> Applies cleanly to 4.0.next.
> 
> It includes a new test suite, LARGE_READX which tests around the boundaries of
> large readX calls with read requests of:
> 
> 0xFFFF0001 (which should return 1 byte).
> 0x10000 (which should always return 0x10000)
> 0x1FFFF (which returns 0x1FFFF on Samba, and 0x10000 on Windows)
> 0x100000 (which returns 0x100000 on Samba, and 0x10000 on Windows).

What are the results without LARGE_READX announced from the client?

I think Samba should return the same as Windows,
except when they're talking a different protocol (unix extentions) to
the client.

For SMB1 (without unix extentions) the largest transport message be
0x1FFFF (including the header).

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130314/5ea50af6/attachment.pgp>