[PATCH 5/7] s3-param: Add lp_set_dos_charset().

Andrew Bartlett abartlet at samba.org
Wed Mar 13 05:17:14 MDT 2013


On Wed, 2013-03-13 at 12:13 +0100, Andreas Schneider wrote:
> On Wednesday 13 March 2013 22:11:03 Andrew Bartlett wrote:
> > On Wed, 2013-03-13 at 11:48 +0100, Andreas Schneider wrote:
> > > Signed-off-by: Andreas Schneider <asn at samba.org>
> > > ---
> > > 
> > >  source3/include/proto.h  | 1 +
> > >  source3/param/loadparm.c | 6 ++++++
> > >  2 files changed, 7 insertions(+)
> > > 
> > > diff --git a/source3/include/proto.h b/source3/include/proto.h
> > > index c36125e..bb73738 100644
> > > --- a/source3/include/proto.h
> > > +++ b/source3/include/proto.h
> > > @@ -1466,6 +1466,7 @@ void lp_remove_service(int snum);
> > > 
> > >  void lp_copy_service(int snum, const char *new_name);
> > >  int lp_default_server_announce(void);
> > >  const char *lp_printername(TALLOC_CTX *ctx, int snum);
> > > 
> > > +void lp_set_dos_charset(const char *name);
> > > 
> > >  void lp_set_logfile(const char *name);
> > >  int lp_maxprintjobs(int snum);
> > >  const char *lp_printcapname(void);
> > > 
> > > diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
> > > index 75b63c5..83fc734 100644
> > > --- a/source3/param/loadparm.c
> > > +++ b/source3/param/loadparm.c
> > > @@ -5316,6 +5316,12 @@ void lp_set_logfile(const char *name)
> > > 
> > >  	debug_set_logfile(name);
> > >  
> > >  }
> > > 
> > > +void lp_set_dos_charset(const char *name)
> > > +{
> > > +	string_set(&Globals.dos_charset, name);
> > > +	init_iconv();
> > > +}
> > > +
> > > 
> > >  /*******************************************************************
> > >  
> > >   Return the max print jobs per queue.
> > >  
> > >  ********************************************************************/
> > 
> > What does this do that lp_set_cmdline("dos charset", name) doesn't do?
> 
> init_iconv();

I'm pretty sure that will be called.  lp_set_cmdline() calls the same
things that an smb.conf setting calls, and that includes
handle_dos_charset() (the special handler for this parameter). 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list