[PATCH] Fix for bug #9706 - Parameter is incorrect on Android
Jeremy Allison
jra at samba.org
Mon Mar 11 19:25:49 MDT 2013
On Mon, Mar 11, 2013 at 02:54:27PM -0700, Jeremy Allison wrote:
> On Mon, Mar 11, 2013 at 01:55:12PM -0700, Jeremy Allison wrote:
> > We need to tweak the 'large read' detection code some more...
>
> Ok, here's a version with the correct MS-doc reference
> in the comment, and also a better order of tests in the
> second part.
>
> Please review (and test :-) and push if you're happy.
Thinking about it the only thing I can think of that might
make the patch cleaner is removal of the check of lp_unix_extensions(),
and always just look at the upper bytes if the client sent us CAP_LARGE_READX.
This is the only thing we looked at in 3.6.x and we never had
these problems with that release :-).
Other Comments/reviews very welcome.
Jeremy.
More information about the samba-technical
mailing list