samba-tool group list patch

[Ricky Nance]

Sorry for the delay, seems like I have either been busy or slightly sick
and not really had the time to revisit this. Everything should be lined up
in this one.

Thanks,
Ricky


On Tue, Feb 19, 2013 at 2:39 PM, Matthieu Patou <mat at samba.org> wrote:

> On 02/19/2013 12:42 AM, Michael Wood wrote:
>
>> Hi
>>
>> On 19 February 2013 06:39, Matthieu Patou <mat at samba.org> wrote:
>> [...]
>>
>>> +                hgtype = hex(int("%s" % msg["grouptype"]) &
>>> 0x00000000FFFFFFFF)
>>> +                if (hgtype == hex(int(security_group.get("**
>>> Builtin")))):
>>> +                    self.outf.write("Security         Builtin\n")
>>> +                elif (hgtype == hex(int(security_group.get("**
>>> Domain")))):
>>> +                    self.outf.write("Security         Domain\n")
>>>
>> [...]
>>
>>> +                else:
>>> +                    self.outf.write("\n")
>>> Can we use a switch ? + precalculated hex
>>> switch(hgtype):
>>>      case HEX_SEC_GRP_BUILTIN:
>>>          ...
>>>      case HEX_SEC_GRP_DOMAIN:
>>>          ...
>>>
>> Unfortunately Python doesn't have a switch statement :)
>>
> Oh really I'm shocked ! I'm surprised I never run into the issue, thanks
> for pointing it.
>
> Most of this issue is close then.
>
>
> --
> Matthieu Patou
> Samba Team
> http://samba.org
>
>


--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-group-list-add-more-info-to-samba-tool-gr.patch
Type: application/octet-stream
Size: 4773 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130311/7ae5b609/attachment.obj>