Nice work! Re: EXPERIMENTAL: tevent_kqueue support

Jeremy Allison jra at samba.org
Fri Mar 8 15:37:50 MST 2013


On Wed, Mar 06, 2013 at 09:11:37PM +0100, Stefan (metze) Metzmacher wrote:

> kqueue is almost done
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=5eb9cc551d9e488daef34ace132a6d7b2e43152c
> as said before it behaves differently than all other backends
> and never give TEVENT_FD_READ and TEVENT_FD_WRITE at the same time
> even if there's one byte in the recv queue no bytes in the send queue.
> 
> And during a make test on freebsd 9 it triggered more failures
> than the poll backend...

Just one comment on this. Do you really need all the panic
fallback code ?

I'm currently writing a Solais ports backend for tevent
(based on the epoll backend) and I'm not planning to have
any of the panic fallback code there.

It either works or it doesn't. Having the fallback to
poll just needlessly complicates the code IMHO.

Jeremy.


More information about the samba-technical mailing list