more -fstack-protector!
Simo
idra at samba.org
Wed Mar 6 09:24:48 MST 2013
On 03/06/2013 10:16 AM, Stefan (metze) Metzmacher wrote:
> Am 06.03.2013 15:22, schrieb Ira Cooper:
>> This patch adds the ability to:
>>
>> --disable-stack-protector (For those who don't want it.)
>> --enable-stack-protector-all (For debugging or the paranoid.)
>>
>> Both builds have been tested locally on illumos. (As far as that they
>> build.)
>>
>> In the future, please don't default flags like this, without a toggle to
>> turn them off.
> Don't we only want -fstack-protector-all and an option to disable it?
>
> I also found -D_FORTIFY_SOURCE=2, do we also want that?
We pass these flags selectively in fedora builds, it would be nice if
waf could simply pick them up when passed to configure, but not build on
it's own as they have performance impact and some people want to be able
to control whether to activate it or not at build.
More information about the samba-technical
mailing list