more -fstack-protector!

[Ira Cooper]

On Wed, Mar 6, 2013 at 10:16 AM, Stefan (metze) Metzmacher
<metze at samba.org>wrote:

> Am 06.03.2013 15:22, schrieb Ira Cooper:
> > This patch adds the ability to:
> >
> > --disable-stack-protector (For those who don't want it.)
> > --enable-stack-protector-all (For debugging or the paranoid.)
> >
> > Both builds have been tested locally on illumos.  (As far as that they
> > build.)
> >
> > In the future, please don't default flags like this, without a toggle to
> > turn them off.
>
> Don't we only want -fstack-protector-all and an option to disable it?
>
> I also found -D_FORTIFY_SOURCE=2, do we also want that?


I'm not sure what the latter does.  I do see people talking about issues
with it in a quick search.

IMHO: The whole thing should be something passed in via CFLAGS/LDFLAGS.
 But I suspect I'm in the minority here.

-Ira