[PATCH] Implement machinepass= in 'net ads join'

Jeremy Allison jra at samba.org
Fri Mar 1 13:30:11 MST 2013


On Thu, Feb 28, 2013 at 11:31:17PM +1100, Andrew Bartlett wrote:
> G'day,
> 
> These patches add (and add tests for) a new machinepass= option for 'net
> ads join'. 
> 
> This makes this match 'samba-tool domain join'.  For master and 4.0,
> this is not strictly required, as a workaround is to call 'samba-tool
> domain join'.  However, I've been asked to backport this to 3.6, for
> Univention at least, and I think having the capability is a reasonable
> addition in any case.
> 
> The only thing is that in all these tools, we don't try and wipe the
> password from the command line, but I'm not worried by this. 
> 
> The first patch is needed because the included tests showed that we in
> fact did not correct set the machine password in the testsuite's calls
> to 'samba-tool', so adding tests here has already been a worthwhile
> exercise.  
> 
> Please review/push/comment.  

Looks good to me ! Pushed to autobuild. Do you want to log
a bug so we can get this back-ported to 4.0.next and
3.6.next ?

Jeremy.


More information about the samba-technical mailing list