[PATCH] Fix crash on Samba AD DC LDAP server

Andrew Bartlett abartlet at samba.org
Mon Jun 24 06:05:25 MDT 2013


On Sat, 2013-06-22 at 17:04 +1000, Andrew Bartlett wrote:
> On Sat, 2013-06-22 at 08:20 +1000, Andrew Bartlett wrote:
> > On Fri, 2013-06-21 at 00:55 -0700, Matthieu Patou wrote:
> > > The patch is good but it means that the search will also never succeed.
> > > 
> > > you can add my review:
> > > 
> > > reviewed-by: Matthieu Patou <mat at matws.net>
> > > 
> > > Don't forget your sign-off !
> > 
> > Not succeeding seems to be the expected thing - attributes without
> > values don't exist in LDAP.
> > 
> > I'll get this in, and in the meanwhile I'm trying to figure out how to
> > write a test for this.
> 
> Tests and fixes for ldb and libcli/ldap (needed for the tests) are
> attached. 
> 
> Please review.
> 
> Thanks,

Additionally this patch bumps the ldb version number.

Please also review this.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list