[PATCH] F_SETLEASE only on regular files.

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Jun 23 01:38:27 MDT 2013


On Sat, Jun 22, 2013 at 10:48:56AM +0200, Andreas Schneider wrote:
> Hello,
> 
> we should set a lease with
> 
>     ret = fcntl(fd, F_SETLEASE, leasetype);
> 
> in source3/smbd/oplock_linux.c only on regular files. Attached is a patch to do
> this. I'm not a VFS expert so the questions is if we shouldn't add errno
> (EINVAL) handling to functions which call SMB_VFS_LINUX_SETLEASE or
> SMB_VFS_NEXT_LINUX_SETLEASE. Maybe at least to not log an error.

Question -- what made you look at this? Is there some real
error that you want to fix?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list