[PATCH] F_SETLEASE only on regular files.

Andreas Schneider asn at samba.org
Sat Jun 22 02:48:56 MDT 2013


Hello,

we should set a lease with

    ret = fcntl(fd, F_SETLEASE, leasetype);

in source3/smbd/oplock_linux.c only on regular files. Attached is a patch to do
this. I'm not a VFS expert so the questions is if we shouldn't add errno
(EINVAL) handling to functions which call SMB_VFS_LINUX_SETLEASE or
SMB_VFS_NEXT_LINUX_SETLEASE. Maybe at least to not log an error.

Cheers,

  -- andreas




More information about the samba-technical mailing list