[PATCH] Fix crash on Samba AD DC LDAP server

Andrew Bartlett abartlet at samba.org
Sat Jun 22 01:04:09 MDT 2013


On Sat, 2013-06-22 at 08:20 +1000, Andrew Bartlett wrote:
> On Fri, 2013-06-21 at 00:55 -0700, Matthieu Patou wrote:
> > The patch is good but it means that the search will also never succeed.
> > 
> > you can add my review:
> > 
> > reviewed-by: Matthieu Patou <mat at matws.net>
> > 
> > Don't forget your sign-off !
> 
> Not succeeding seems to be the expected thing - attributes without
> values don't exist in LDAP.
> 
> I'll get this in, and in the meanwhile I'm trying to figure out how to
> write a test for this.

Tests and fixes for ldb and libcli/ldap (needed for the tests) are
attached. 

Please review.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Cope-with-substring-match-with-no-chunks-in-ldb_.patch
Type: text/x-patch
Size: 1068 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130622/3572ca5c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-libcli-ldap-Cope-with-substring-match-with-no-chunks.patch
Type: text/x-patch
Size: 2185 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130622/3572ca5c/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-torture-Add-tests-for-LDAP-substring-search-with-no-.patch
Type: text/x-patch
Size: 4591 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130622/3572ca5c/attachment-0002.bin>


More information about the samba-technical mailing list