[PATCH] vfs_glusterfs: New file creation fix.
Jeremy Allison
jra at samba.org
Fri Jun 21 11:07:00 MDT 2013
On Thu, Jun 20, 2013 at 08:40:21PM -0500, Christopher R. Hertel wrote:
> > move the -1 return into the previous bracketed code as it's
> > already checking for -1) - something like this:
> >
> > diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
> > index 24e1bda..1323e0e 100644
> > --- a/source3/modules/vfs_glusterfs.c
> > +++ b/source3/modules/vfs_glusterfs.c
> > @@ -894,8 +894,10 @@ static int vfs_gluster_get_real_filename(struct vfs_handle_struct *handle,
> > "user.glusterfs.get_real_filename:%s", name);
> >
> > ret = glfs_getxattr(handle->data, path, key_buf, val_buf, NAME_MAX + 1);
> > - if (ret == -1 && errno == ENODATA) {
> > - errno = EOPNOTSUPP;
> > + if (ret == -1) {
> > + if (errno == ENODATA) {
> > + errno = EOPNOTSUPP;
> > + }
> > return -1;
> > }
> >
> > but I'm not too hung up on it.
> >
> > Can we get another Team member review and I'll push ?
> >
> > Thanks,
> >
> > Jeremy.
> >
>
> +1
>
> Raghavendra Talur created the original patch. It was good, but Jeremy's
> version is a little more concise. Jose Rivera has built and tested with
> this patch and the results are good.
Pushed, thanks !
Jeremy.
More information about the samba-technical
mailing list