[PATCH] vfs_streams_xattr: Do not attempt to write empty attributetwice

Scott Lovenberg scott.lovenberg at gmail.com
Thu Jun 13 13:56:23 MDT 2013

On Thu, Jun 13, 2013 at 3:50 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> That is probably true. But I think that this should be made
> obvious with braces. I find the operator precedence of || vs
> && less than obvious, and a bit of redundancy does not hurt
> here I guess.
> Looking at that whole routine, I think the general logic
> could be simplified quite a bit. (I know, much of that stuff
> is mine...)
> Volker

Yeah, I didn't even consider operator order until the second glance.
The binary will probably be the same either way and Volker's advise
makes the code much more readable.

Peace and Blessings,

More information about the samba-technical mailing list