[PATCH]: core files with make testenv and [PROPOSAL] Depricate the 'enable core files' option for 4.1?

Andrew Bartlett abartlet at samba.org
Thu Jun 13 04:08:24 MDT 2013

On Wed, 2013-06-05 at 12:00 +0200, Gregor Beck wrote:
> Am Montag, 3. Juni 2013, 22:52:10 schrieb Andrew Bartlett:
> > On Mon, 2013-06-03 at 14:47 +0200, Gregor Beck wrote:
> > > Hi Andrew,
> > > 
> > > I did not understand the reasons for doing chown here, so I tried to make
> > > it work.
> > > Maybe removing it alltogether is the right thing todo.
> > 
> > Are there any clues in the git history for this?
> The chown is part of the initial commit from 1996 with the following comment 
> preceding the dump_core() function:
> "prepare to dump a core file - carefully!"
> Seems a little paranoid.

I started looking into this, and wondered what you thought of this
patch.  I still can't get smbd to dump core with it in 'make testenv',
but your comments and thoughts would be very welcome.

I re-use existing modern code for making the safe directory, and try to
make this more generic, so we could use it across all of Samba.  I don't
rely on the log directory, instead using a compiled in directory that we
don't have to check for changes. 


I would also like to depreciate this for 4.1, so I can remove it from
master once we fork.  Can you enlighten me on why you added it in 2006
(0ed76af63d25fe98fc0366708675a514a3c5bddb), given the manpage says "You
should never need to change this"?

You might well ask why am I so 'anti options'?  While we have
workarounds of various types, essentially lp options in low-level code
make it harder to share and use, because it adds a dependency on at
least one of our high-level loadparm libraries.  We also see the
ordering issues we have that obnox brought up, as we try and cope with
before and after loading situations.  

While not impossible, it would be easier to then add careful core
control to 'samba' for example if we didn't have this option. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-lib-dump_core-Rework-core-dumping-code-to-just-du.patch
Type: text/x-patch
Size: 9209 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130613/a10e4e62/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-param-Deprecate-enable-core-files-to-make-mergin.patch
Type: text/x-patch
Size: 1502 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130613/a10e4e62/attachment-0001.bin>

More information about the samba-technical mailing list