[PATCH] Change md5 detection to cope with OpenIndiana
abartlet at samba.org
Wed Jun 12 03:22:31 MDT 2013
On Mon, 2013-06-10 at 10:50 +0200, Volker Lendecke wrote:
> Hi, Andrew!
> On Sat, Jun 08, 2013 at 05:56:05PM +1000, Andrew Bartlett wrote:
> > This changes (again...) our system md5 detection to cope with how
> > OpenSolaris does md5. I'm becoming increasingly convinced this isn't
> > worth our while (we should have just done samba_md5...), but for now
> > this change seems to work on FreeBSD, OpenIndiana and Linux with libbsd.
> This might be the case for MD5. But I would like to point
> out that in general I would strongly look at system-provided
> crypto libs for one reason: Hardware support. There probably
> is no MD5 hardware, but I am not sure I want to add
> assembler to Samba to support the AES instructions.
> System-provided libraries or even the kernel has a much
> better chance to do this than we have.
As I think we are in agreement on why this is worthwhile anyway, despite
being difficult, is there any chance you might be able to review and
push the change?
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical