Quite some time on the train made me look into the code again

Michael Adam obnox at samba.org
Mon Jun 10 15:09:54 MDT 2013

Hi Luk,

Thanks for your patches.  I and metze reviewed them, and as just
discussed on IRC they are generally good, but there are a few

- One of the patches does not compile beacuse it uses
  non-existing smb2cli_conn_capabilities()

- I suggest to make the new wrappers consistent in their
  access to conn->smb1.capabilites: currently one uses
  the accessor smb1cli_conn_capabilites() and the others don't.

I pushed the newly rebased and partly tagged branch to

I'd be fine if you just pushed updated patches to your private
repo and pust the update here instead of sending update versions
of the patches to the list.

Cheers - Michael

On 2013-05-18 at 10:50 +0200, Luk Claes wrote:
> Hi
> Last year I started to make libsmb less SMB1 specific. As it was unclear to me how to continue I stopped working on it. Looking again at the code now I saw some similar patterns as last year and some new ideas to work on. What's still unclear to me is how we will be able to solve the additional_flags mess. Any ideas welcome!
> Please review and feel free to push if you like the patches!
> Cheers
> Luk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130610/99185b0a/attachment.pgp>

More information about the samba-technical mailing list