[PATCH] Change md5 detection to cope with OpenIndiana

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Jun 10 02:50:30 MDT 2013


Hi, Andrew!

On Sat, Jun 08, 2013 at 05:56:05PM +1000, Andrew Bartlett wrote:
> This changes (again...) our system md5 detection to cope with how
> OpenSolaris does md5.  I'm becoming increasingly convinced this isn't
> worth our while (we should have just done samba_md5...), but for now
> this change seems to work on FreeBSD, OpenIndiana and Linux with libbsd.

This might be the case for MD5. But I would like to point
out that in general I would strongly look at system-provided
crypto libs for one reason: Hardware support. There probably
is no MD5 hardware, but I am not sure I want to add
assembler to Samba to support the AES instructions.
System-provided libraries or even the kernel has a much
better chance to do this than we have.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list