Review request: Bug #9632

[Andrew Bartlett]

On Sun, 2013-06-09 at 09:53 +0200, Kai Blin wrote:
> Hi folks,
> 
> two weeks ago I fixed bug #9632 (DNS can't handle large packets), but I 
> still need a review to get the patches into 4.0. Can someone please 
> review so we can get this to our users pre-4.1?
> 
> Cheers,

Kai,

I'm always happy to review patches.  To get patches in bugzilla to my
review attention, please set the review flag in the detail on the patch
to ? and then my e-mail address.  

https://bugzilla.samba.org/attachment.cgi?id=8920&action=edit

I realise it feels like 'make-work', but please 'git cherry-pick -x' the
patches into a branch of 4.0, and then upload the git format-patch -1
output, as it provides us with a link between the patches, so if issues
are found with it later, we can follow the original context in master.

I know the process can feel painful, but this much seems to work OK as a
practice for getting patches into 4.0, and causes a mail to be generated
to me that I can quickly act on.  Also, by asking specifically to my
attention I can see your review request in this query, to help me catch
up when I've been swamped:

https://bugzilla.samba.org/buglist.cgi?type0-1-0=notequals;query_format=advanced;value0-1-0=ks%40sernet.de;field0-1-0=assigned_to;field0-0-0=requestees.login_name;bug_status=NEW;bug_status=ASSIGNED;bug_status=REOPENED;email1=abartlet;type0-0-0=equals;value0-0-0=abartlet%40samba.org;emailtype1=substring

And for your curiosity, I can see my own review requests with this one:

https://bugzilla.samba.org/buglist.cgi?type0-1-0=notequals&query_format=advanced&value0-1-0=ks%40sernet.de&emailcc1=1&emailreporter1=1&field0-1-0=assigned_to&field0-0-0=setters.login_name&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=abartlet&type0-0-0=equals&value0-0-0=abartlet%40samba.org&emailtype1=substring

I hope this helps avoid your patches getting lost again, because I very
much value your contribution here.  

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org